Dialer's Header parameter doesn't work as intended

[Gekko0114]

Hello Gobwas,

Thanks for the great package!

I found that httpWriteUpgradeRequest doesn't work as intended. When I try to add dial function like this:

        dialer := &ws.Dialer{
            Header:  ws.HandshakeHeaderHTTP(h),
        }

I want to assign request's header to h, but it doesn't work as expected due to this code httpWriteHeader(bw, headerHost, u.Host). This causes both h and u.Host to be assigned to the request's header.

I hope this problem can be resolved soon. Thanks,

FYI We discussed this problem in this PR.

[cristaloleg]

Thanks for the info, will take a look shortly. Do you have a fix (even a theoretical) for that btw ?

[Gekko0114]

You can fix it by replacing httpWriteHeader(bw, headerHost, u.Host) with the following code:

    host := u.Host
    if headerHTTP, ok := header.(HandshakeHeaderHTTP); ok {
        httpHeaderHTTP := http.Header(headerHTTP)
        if v := httpHeaderHTTP.Get(headerHost); v != "" {
            host = v
        }
    }

    httpWriteHeader(bw, headerHost, host)

And you need to comment out https://github.com/gobwas/ws/blob/master/http.go#L323-L325.

However, since handshakeheader is an interface, so I don't think my code is a perfect solution. My solution is specific to HandshakeHeaderHTTP type.

I think you should decide how to fix it because this solution is related to this library's design itself.

[matthyx]

@cristaloleg have you looked at this?

[cristaloleg]

Yes, but AFAIR we didn't found a solution. Feel free to make a PR.

[matthyx]

Yes, but AFAIR we didn't found a solution. Feel free to make a PR.

Please have a look at: https://github.com/gobwas/ws/pull/194 Merry Christmas!

[cristaloleg]

Fixed in https://github.com/gobwas/ws/releases/tag/v1.3.2