search

gobwas / ws

Tiny WebSocket library for Go.
MIT License
6.1k stars 373 forks source link

ws: bring back support for go1.16 #172

Closed ZekeLu closed 1 year ago

ZekeLu commented 1 year ago

Running go1.16 build . failed with:

//go:build comment without // +build comment

Fixes chromedp/chromedp#1310.

cristaloleg commented 1 year ago

Hi, any reasons to live on 1.16 ? That's an old version.

ZekeLu commented 1 year ago

Hi, chromedp is a module used by many users. Some of the users just can't upgrade to go1.17+. In fact, we have tried to drop support for go1.16, but later we decided to bring it back (see this commit https://github.com/chromedp/chromedp/commit/5aeb67f507367db6b51eb9464578d0478151a2ff).

cristaloleg commented 1 year ago

Done https://github.com/gobwas/ws/releases/tag/v1.2.1

ZekeLu commented 1 year ago

Wow, so quick! Thank you!

BTW, I saw the release note for v1.2 states that this package will drop support for go1.16. May I know why? Are you planning to do something new that it's a big burden to support go1.16?

cristaloleg commented 1 year ago

Well, we had a plan to drop support of old versions (there are a few places from what I remember). But after this PR I think we should postpone it.