Remove common wsutil.Reader allocations

gobwas / ws

Tiny WebSocket library for Go.

MIT License

6.1k stars 373 forks source link

Closed klauspost closed 10 months ago

klauspost commented 10 months ago

ws.ReadHeader allocates a 12 byte temporary buffer to read the header into. Since io.ReadFull is used, it escapes to the heap.
wsutil.NewCipherReader is allocated on each call to NextFrame.

Since the NextFrame shouldn't have concurrent calls, both of these should be possible to have internally.

I am forced to copy "readHeader" from ws, since there is not way to eliminate the alloc otherwise as far as I can tell.

cristaloleg commented 10 months ago

Thanks! I will finish #171 tomorrow and will release a new version.

cristaloleg commented 10 months ago