search

goby-lang / goby

Goby - Yet another programming language written in Go
MIT License
3.49k stars 171 forks source link

[WIP] #677 Ternary Expression Implementation #794

Open Alexius-Huang opened 4 years ago

Alexius-Huang commented 4 years ago

I'm trying.

Issue #677

codecov[bot] commented 4 years ago

Codecov Report

Merging #794 into master will increase coverage by 0.02%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #794      +/-   ##
==========================================
+ Coverage    80.3%   80.32%   +0.02%     
==========================================
  Files          54       54              
  Lines        7417     7417              
==========================================
+ Hits         5956     5958       +2     
+ Misses       1234     1233       -1     
+ Partials      227      226       -1
Impacted Files Coverage Δ
compiler/parser/parser.go 94.07% <ø> (ø) :arrow_up:
compiler/token/token.go 100% <ø> (ø) :arrow_up:
compiler/parser/expression_parsing.go 70% <ø> (ø) :arrow_up:
compiler/lexer/lexer.go 95.6% <100%> (+0.73%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7ae1131...0c8c71e. Read the comment docs.

st0012 commented 4 years ago

👍 Although I seldom find ternary expression useful (too hard to find 3 expressions all simple and short enough to put into the same line). I'm quite curious about what the implementation would be.

st0012 commented 4 years ago

@Maxwell-Alexius any update on this?