search

goby-lang / goby

Goby - Yet another programming language written in Go
MIT License
3.49k stars 171 forks source link

Cleanup goby binary executable for the case that test fails #803

Closed hachi8833 closed 4 years ago

hachi8833 commented 4 years ago

Small fix. make test performs go clean . to cleanup the local goby binary executable when test fails.

codecov[bot] commented 4 years ago

Codecov Report

Merging #803 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #803   +/-   ##
=======================================
  Coverage   80.25%   80.25%           
=======================================
  Files          54       54           
  Lines        7403     7403           
=======================================
  Hits         5941     5941           
  Misses       1237     1237           
  Partials      225      225

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 48382be...30f712b. Read the comment docs.

st0012 commented 4 years ago

@hachi8833 can you provide some numbers so we can have a clearer view of the benefits from the improvement?

hachi8833 commented 4 years ago

The remained binary executable sometimes disturbs rerunning tests. Just to rm -rf goby resolves the issue, but I think this can be automated.