search

goby-lang / goby

Goby - Yet another programming language written in Go
MIT License
3.48k stars 171 forks source link

Make t.builtinMethodYield return an Object instead of a Pointer #848

Closed st0012 closed 4 years ago

st0012 commented 4 years ago

Most of the time, we use the return value of t.builtinMethodYield as an object instead of pushing it to the stack (as a Pointer). So it doesn't need to and shouldn't return a pointer, which costs us an extra attribute call in many cases.

codecov[bot] commented 4 years ago

Codecov Report

Merging #848 into master will decrease coverage by 0.01%. The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #848      +/-   ##
==========================================
- Coverage   81.04%   81.02%   -0.02%     
==========================================
  Files          54       54              
  Lines        7500     7496       -4     
==========================================
- Hits         6078     6074       -4     
  Misses       1188     1188              
  Partials      234      234
Impacted Files Coverage Δ
vm/simple_server.go 67.96% <0.00%> (ø)
vm/http.go 84.61% <50.00%> (ø)
vm/thread.go 90.45% <80.00%> (ø)
vm/array.go 96.32% <100.00%> (-0.02%) :arrow_down:
vm/block.go 56.75% <100.00%> (ø)
vm/class.go 86.35% <100.00%> (-0.02%) :arrow_down:
vm/concurrent_rw_lock.go 88.23% <100.00%> (ø)
vm/hash.go 96.83% <100.00%> (-0.01%) :arrow_down:
vm/range.go 93.29% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 283b108...e6c3641. Read the comment docs.

st0012 commented 4 years ago

@saveriomiroddi thanks for the quick review!

64kramsystem commented 4 years ago

@saveriomiroddi thanks for the quick review!

This was a simple one :joy: