search

goby-lang / goby

Goby - Yet another programming language written in Go
MIT License
3.48k stars 171 forks source link

Add t.Helper() to goby_test.go #855

Closed hachi8833 closed 4 years ago

hachi8833 commented 4 years ago

https://github.com/ichiban/thelper/ suggests that the followings tests forgot to call t.Helper().

/Users/hachi8833/go/src/github.com/goby-lang/goby/goby_test.go:32:1: unmarked test helper: call t.Helper()
/Users/hachi8833/go/src/github.com/goby-lang/goby/compiler/compiler_test.go:17:1: unmarked test helper: call t.Helper()
/Users/hachi8833/go/src/github.com/goby-lang/goby/native/db/db_test.go:10:1: unmarked test helper: call t.Helper()
/Users/hachi8833/go/src/github.com/goby-lang/goby/native/plugin/plugin_integration_test.go:76:1: unmarked test helper: call t.Helper()
/Users/hachi8833/go/src/github.com/goby-lang/goby/vm/concurrent_rw_lock_test.go:305:1: unmarked test helper: call t.Helper()
/Users/hachi8833/go/src/github.com/goby-lang/goby/vm/hash_test.go:1904:1: unmarked test helper: call t.Helper()

Recent Go has t.Helper(), which is not mandatory but this helps read the error messages during tests.

codecov[bot] commented 4 years ago

Codecov Report

Merging #855 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #855   +/-   ##
=======================================
  Coverage   81.06%   81.06%           
=======================================
  Files          54       54           
  Lines        7498     7498           
=======================================
  Hits         6078     6078           
  Misses       1187     1187           
  Partials      233      233

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2cf5b85...8a9647c. Read the comment docs.