URL parameter encoding is not Culture Invariant

gocardless / gocardless-legacy-dotnet

The .NET client library for the GoCardless Legacy API

https://nuget.org/packages/GoCardless/

MIT License

12 stars 15 forks source link

URL parameter encoding is not Culture Invariant #6

Closed banderous closed 11 years ago

banderous commented 11 years ago

A Ukrainian user encountered a problem with the URLs generated by the .NET library. Specifically, decimal numbers were formatted with a comma "," decimal separator.

All our parameter ToString() formatting calls should use the overload that takes a CultureInfo parameter, and supply CultureInfo.InvariantCulture.

timiles commented 11 years ago

You're right. Have created a unit test to catch this case, and applied the fix. Latest version (1.1.4) is now available on NuGet. Good spot & apologies!