search

gocardless / gocardless-pro-python

GoCardless Pro Python Client
MIT License
37 stars 26 forks source link

Proxy support #13

Open glut23 opened 7 years ago

glut23 commented 7 years ago

In our integration with GoCardless we need to be able to use a proxy to communicate with the API. Currently there is no option available in the library to do so. As the library uses requests it would be great if we could specify the proxies parameter that this function accepts. Would it be possible to add support for using a proxy?

timrogers commented 7 years ago

@glut23 Thanks for your issue! Your request makes total sense to me - we'll have a bit more of a think about this, and aim to get back to you within the next week or so.

timrogers commented 7 years ago

I'd love to know what the use case is for using a proxy to interact with the GoCardless API too - would you give me a bit more information?

glut23 commented 7 years ago

@timrogers sure, any request coming from our apps that needs to go to the internet go out via a proxy (squid proxy server in our case). We implemented a temporal solution to make it work monkey patching your ApiClient for one that adds the proxies in the requests. Of course doing this is not ideal and it would be great to have this feature supported by the library. Thanks in advance.

timrogers commented 7 years ago

@glut23 Thanks! We'll have a think about this - it's something we'd like to do, but it might take us a little while to get to it.