search

gocardless / pgreplay-go

Postgres load testing tool
MIT License
113 stars 15 forks source link

Fix on csv parser #24

Closed danicaceres1998 closed 9 months ago

danicaceres1998 commented 9 months ago

hi @chill, sorry but I noticed an error on my last PR that you merged 😆.

On my last commit I got introduced a bug, this is the fix. Even if the reader.Read() returns an error it also returns the slice of strings, so we've to continue the sequence.

With this change all the tests are green again.

chill commented 9 months ago

My mistake, I'd assumed we wouldn't get anything back in that case too :), thanks for the quick fix!