Make generators more rubocop friendly

gocardless / statesman

A statesmanlike state machine library.

https://gocardless.com/blog/statesman/

MIT License

1.78k stars 163 forks source link

Make generators more rubocop friendly #327

Closed greysteil closed 6 years ago

greysteil commented 6 years ago

Statesman only support Ruby 2.2+, so we can use %i(...) syntax for symbol arrays
Using single quotes and double quotes inconsistently was never necessary

Won't make the generators fit everyone's rubocop setup, but will mean they have a chance of fitting some people's.

Regen of #288 to try to fix CI.

nickcampbell18 commented 6 years ago

Hi @greysteil, looks like Statesman wasn't correctly configured to build forks & OSS 🤦‍♂️ . Would you mind force-pushing a new SHA to try and trigger a fresh build please?

greysteil commented 6 years ago

Done. Doing better, but looks like that mongo image is missing.

danwakefield commented 6 years ago

We've just added a new version so if you rebase it'll work now.