Deprecate ActiveRecord::Base.default_timezone

gocardless / statesman

A statesmanlike state machine library.

https://gocardless.com/blog/statesman/

MIT License

1.78k stars 163 forks source link

Deprecate ActiveRecord::Base.default_timezone #446

Closed floriandejonckheere closed 2 years ago

floriandejonckheere commented 2 years ago

Rails 7.0 deprecates ActiveRecord::Base.default_timezone in favour of ActiveRecord.default_timezone. Rails 7.1 will remove this method entirely. To prevent deprecation warnings in 7.0, the gem should default to the new method.

shkm commented 2 years ago

@thom-oman not quite sure who to ping so apologies if you're not the right one for this, but what's the state of statesman (heheh)? It'd be great if we could get this tiny change in.

thom-oman commented 2 years ago

Hey @shkm! Yeah I'm still keeping an eye on statesman but still finding less time than I'd like. So it's definitely not been receiving the love it deserves over the past few months 😅 but leave that with me, I'm going to try get the ball moving on that today.

In terms of this PR, I will also release it today, so we can get rid of those annoying warnings! :)

Apologies again for the slowness, think this PR in particular was missed over the christmas period.