search

gocardless / statesman

A statesmanlike state machine library.
https://gocardless.com/blog/statesman/
MIT License
1.78k stars 163 forks source link

Fixed issue with transitions using STI #503

Closed pedro-pedrosa closed 1 year ago

pedro-pedrosa commented 1 year ago

Prior to 7.2.0 the code to unset the most_recent column of old transitions when a new transition was created relied on transitions_for_parent, which would build the correct query in the case that the transition class was using single table inheritance.

However, after #399, the code no longer uses the parent association to create the query and the current custom query lacks this functionality that existed prior to 7.2.0.

This PR addresses this issue by adding an AND clause to the query to filter by transition type if the transition class contains an inheritance column.

artyrcheek commented 1 year ago

Would love this to get merged, currently being bitten by this. Thanks @pedro-pedrosa