gocardless / theatre

GoCardless' collection of Kubernetes extensions
MIT License
23 stars 17 forks source link

Fix detaching from interactive consoles #231

Closed dyson closed 3 years ago

dyson commented 3 years ago

Currently detaching from a console is not behaving as expected and we appear to hang once detached. What happens is the following:

You create an interactive console with a tty
You detach using CTRL-p CTRL-q
The cli is now stuck in c.waitForSuccess as the console is in a running state
You can CTRL-c to kill the cli to escape

To resolve this we shouldn't be waiting for success after we exit from an interactive console (either from completion or detaching). This used to be the case but the behaviour changed when support for attaching to non-interactive consoles (this streams the consoles stdout) was added.