gocardless / theatre

GoCardless' collection of Kubernetes extensions
MIT License
23 stars 17 forks source link

Convert gocardless/theatre to GitHub Actions #267

Closed sam-robson closed 1 year ago

sam-robson commented 1 year ago

Pipeline migrated from Circle CI :tada:

Manual steps

Perform the follow steps to complete the migration:

gocardless/theatre/build-integration

Raúl updated:

Webhooks can specify what versions of AdmissionReview objects they accept with the admissionReviewVersions field in their configuration:

apiVersion: admissionregistration.k8s.io/v1
kind: ValidatingWebhookConfiguration
webhooks:
- name: foo.gocardless.com
  admissionReviewVersions: ["v1", "v1beta1"]

Integration testing is failing

The following integration test is also failing:

Summarizing 4 Failures:

[Fail] Acceptance Consoles [It] Happy path 
/home/runner/work/theatre/theatre/cmd/workloads-manager/acceptance/acceptance.go:118

[Fail] Acceptance Consoles Runner interface [It] Happy path 
/home/runner/work/theatre/theatre/cmd/workloads-manager/acceptance/acceptance.go:242

[Fail] Acceptance Consoles [It] Deleting a console template 
/home/runner/work/theatre/theatre/cmd/workloads-manager/acceptance/acceptance.go:415

[Fail] Acceptance Consoles [It] Deleting a job 
/home/runner/work/theatre/theatre/cmd/workloads-manager/acceptance/acceptance.go:460

Ran 8 of 8 Specs in 16.624 seconds
FAIL! -- 4 Passed | 4 Failed | 0 Pending | 0 Skipped

I had runed this locally, and I consistently get similar errors. So I think it is best to get this change in and handle the acceptance tests in a following PR