UnmarshalToCallback eats custom unmarshaller error

gocarina / gocsv

The GoCSV package aims to provide easy CSV serialization and deserialization to the golang programming language

MIT License

1.99k stars 245 forks source link

UnmarshalToCallback eats custom unmarshaller error #130

Open nikolay-turpitko opened 5 years ago

nikolay-turpitko commented 5 years ago

I tried to use custom time converter from README and used UnmarshalToCallback function. It didn't return error for wrong time format and silently returned nil, never calling callback. I changed my code to use UnmarshalToChan with go routine and wait group and error is actually returned by UnmarshalToChan. So, I suppose, some issue is inside for loop near select on the error channel. Probably, some race condition in case of error or short input streams.

millerlogic commented 4 years ago

Not only custom error, but I didn't get an error from a bad csv file. It silently chugs along giving false info.

krazik-intuit commented 2 years ago

yeah just ran into this too. gonna try to pr to fix it.