search

gocarina / gocsv

The GoCSV package aims to provide easy CSV serialization and deserialization to the golang programming language
MIT License
1.99k stars 245 forks source link

UnmarshalToCallback functions don't return reader's error #256

Closed TelpeNight closed 1 year ago

TelpeNight commented 1 year ago

I've added a testcase for this situation. Current implementation will just ignore pending error.

It should be safe to use pure read of cerr chans in these cases. Functions reach final return statements only when c is closed. So UnmarshalToChan returned successfully and wrote to cerr.

pikanezi commented 1 year ago

Thanks!