gocario / PHBank

[3DS] Pokémon Homebrew Bank
https://gbatemp.net/threads/398718/
GNU General Public License v3.0
157 stars 17 forks source link

Store the pk folder data inside ROMFS #31

Open DanTheMan827 opened 8 years ago

DanTheMan827 commented 8 years ago

I think it would make more sense to store the template data, move list, etc inside the ROMFS rather than have the user extract it to the SD card...

You could also store the blank bank file there and copy it to the SD card if it doesn't exist.

gocario commented 8 years ago

For the most of the files, I try to load from sdmc:/ then romfs:/ (ie: https://github.com/gocario/PHBank/blob/master/source/data_manager.cpp#L141-L150) But something wasn't working, no idea why, I didn't worked on it that much afterward.

I don't want to place the bank file into the SaveArchive tho, because it has to be shared between the .cia and the .3dsx version. (The blank bank file is just a file filled with zeroes)

DanTheMan827 commented 8 years ago

Ah, yeah... I wasn't saying store the bank file in SaveArchive...

You seem to have a few folders inside the pk folder in the rar archive that look to be localization files that I was talking about... is it necessary to put those on the SD card anymore?

gocario commented 8 years ago

Yeah, the romfs problem is still here, I haven't put my head in for a while, and I have other things to do.