search

goccmack / gocc

Parser / Scanner Generator
Other
618 stars 48 forks source link

main: remove unused functions #90

Closed shivansh closed 5 years ago

awalterschulze commented 5 years ago

Looks like we have a problem with go1.10 on travis, but otherwise this looks good to ship

shivansh commented 5 years ago

The build failure is due to errcheck failing on go1.10 (https://github.com/kisielk/errcheck/issues/167) and IMO is unrelated to the changes introduced in this PR.

awalterschulze commented 5 years ago

Can we remove the go1.10 check and replace it with a newer version?

shivansh commented 5 years ago

Yes, I think we can temporarily disable go1.10 from the travis builds until this issue is resolved in errcheck.

awalterschulze commented 5 years ago

Or permanently

shivansh commented 5 years ago

Sure. With #93 merged, I think this PR is also good to merge ?

awalterschulze commented 5 years ago

Agreed