goccy / bigquery-emulator

BigQuery emulator server implemented in Go
MIT License
845 stars 108 forks source link

Did the WriteStream API forget to commit the transaction when the WriteStream Type is set to WriteStream_COMMITTED? #231

Open Ubisoft-potato opened 1 year ago

Ubisoft-potato commented 1 year ago

When I set the WriteStream type to WriteStream_COMMITTED, I noticed that not all of the data was being saved. Upon investigating the following code snippet:

https://github.com/goccy/bigquery-emulator/blob/main/server/storage_handler.go#L507 https://github.com/goccy/bigquery-emulator/blob/main/server/storage_handler.go#L513

It seems that the transaction was not being committed.