search

goccy / bigquery-emulator

BigQuery emulator server implemented in Go
MIT License
743 stars 86 forks source link

Handle `formatOptions.useInt64Timestamp` in `tabledataListRequest` #276

Closed ohaibbq closed 1 month ago

ohaibbq commented 3 months ago

Closes #275

Gyllsdorff commented 1 month ago

It looks like the only conflict is in go.mod and go.sum. Do you see any risks in doing a bump of all dependencies in this PR or are there any reasons to leave some deps on a older version?

This problem caused about 2 days of extra work until I saw what was wrong so it would be great if we could merge and release a fix.

ohaibbq PR is in a forked repo so I can't resolve the minor conflicts, I could fork-the-fork, resolve the conflict and create a new PR but that would be rude to Ohaibbq that did all the work. :)

ohaibbq commented 1 month ago

@goccy I've updated the dependencies and fixed a test failure

goccy commented 1 month ago

LGTM 👍