search

goccy / go-json

Fast JSON encoder/decoder compatible with encoding/json for Go
MIT License
3.11k stars 148 forks source link

Reset runtime context options before releasing it back into pool #500

Open lovromazgon opened 8 months ago

lovromazgon commented 8 months ago

This PR makes sure RuntimeContext options are reset before the context is returned to the pool.

It also adds a test case that fails without the change.

Fixes #499.

lovromazgon commented 8 months ago

@goccy any chance you could look at the issue and PR? To me, it seems like a pretty straightforward fix.

goccy commented 6 months ago

Sorry for the late reply, Please re-commit to run CI 🙏

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.53%. Comparing base (df897ae) to head (abd07bc). Report is 4 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #500 +/- ## ========================================== + Coverage 76.78% 78.53% +1.74% ========================================== Files 55 55 Lines 18922 16714 -2208 ========================================== - Hits 14529 13126 -1403 + Misses 3759 2956 -803 + Partials 634 632 -2 ```
lovromazgon commented 6 months ago

@goccy I see you released 0.10.3, is there anything missing here that prevented you from including this PR?

goccy commented 6 months ago

I saw this PR, but I cannot accept this implementation.

lovromazgon commented 6 months ago

Can you elaborate? Do you have suggestions on other approaches to address this bug?

EDIT: I assume you're concerned about the allocation. How about the approach with setting the context to nil before releasing it?

lovromazgon commented 5 months ago

Any chance you had a look at the last commit @goccy? Or at least describe your concerns so I know how to address them.

lovromazgon commented 5 months ago

@goccy can you please respond? I am willing to do the work and fix the bug, but I can't do it without your cooperation.

lovromazgon commented 4 months ago

A friendly reminder that I'm waiting for a response.

lovromazgon commented 2 months ago

Bump.