goccy / go-yaml

YAML support for the Go language
MIT License
1.12k stars 129 forks source link

Fix handle of space at start or last #376

Closed ozraru closed 1 year ago

codecov-commenter commented 1 year ago

Codecov Report

Merging #376 (7a9ece1) into master (42fb764) will not change coverage. The diff coverage is 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #376 +/- ## ======================================= Coverage 75.61% 75.61% ======================================= Files 13 13 Lines 4650 4650 ======================================= Hits 3516 3516 Misses 874 874 Partials 260 260 ```
ozraru commented 1 year ago

@goccy Could you review, please?

goccy commented 1 year ago

@ozraru Basically, the spaces before and after are automatically removed and converted to tokens, so please add specific use cases to the test cases (e.g. encode_test.go and decode_test.go )

ozraru commented 1 year ago

@goccy done

goccy commented 1 year ago

LGTM