goccy / go-yaml

YAML support for the Go language
MIT License
1.12k stars 129 forks source link

Run yaml-test-suite on CI #465

Open mx-psi opened 1 month ago

mx-psi commented 1 month ago

Is your feature request related to a problem? Please describe.

Correctness is one of the most important priorities for a parsing library. As evidenced by issues like #460, #455, #407, #406 and #399 among others, this library has quite a few edge cases in which parsing does not work correctly (i.e. according to the YAML specificaiton). While this is not uncommon in YAML implementations, it anecdotically seems like go-yaml has more bugs than other libraries, or at least bugs in some more common cases.

Describe the solution you'd like

yaml/yaml-test-suite is a language agnostic test suite widely used for ensuring conformance. Adding this test suite on CI would greatly help in reducing the amount of bugs in this library. All tests that fail today could be skipped and tracked, and existing issues could be tied to failing tests in the test suite.

Describe alternatives you've considered

Do nothing?

Additional context

I was considering this library for adoption in the opentelemetry-collector repository, this is one of the blockers in my view.