search

gocd-contrib / docker-elastic-agents-plugin

Docker-based elastic agents for GoCD
https://www.gocd.org
Apache License 2.0
31 stars 40 forks source link

Feature Request: Support further resource constraints options #291

Open gklittlejohn opened 2 months ago

gklittlejohn commented 2 months ago

When attempting to limit resource usage via the CPUs field for a Windows container gives an error occurs when trying to create the container "body: {"message":"invalid option: Windows does not support CPUPeriod"}".

It should be possible to limit CPU resource usage for Windows containers via the --cpus, --cpu-percent and --cpu-shares flags. Ideally these would be surfaced on the agent profile configuration.

chadlwilson commented 2 months ago

Are you willing to.make changes, test and submit a PR? I don't really have an environment to test within as don't have native windows hardware, only ARM VMs.

Can test more easily with the ECS plugin than this non-orchestration variant.