Rework the environment variable methods.

gocd-contrib / gomatic

A Python API for configuring GoCD

https://pypi.python.org/pypi/gomatic

MIT License

142 stars 60 forks source link

Rework the environment variable methods. #20

Closed doctoryes closed 7 years ago

doctoryes commented 7 years ago

Add a common mixin that implements a common set of environment variables methods for pipelines, stages, and jobs. Also, minor file rename and README update.

doctoryes commented 7 years ago

@macdiesel @cpennington Please review.

macdiesel commented 7 years ago

I'm a +1 on the change, but we should rework the tests to go along with this.

doctoryes commented 7 years ago

Zero change in functionality - but more code re-organization/removal. Ready for re-review. @macdiesel What type of test rework/changes do you think are missing?

doctoryes commented 7 years ago

@clintonb FYI.

doctoryes commented 7 years ago

@macdiesel This PR is ready to roll.