gocd-contrib / gomatic

A Python API for configuring GoCD
https://pypi.python.org/pypi/gomatic
MIT License
142 stars 60 forks source link

Modify artifacts definition to include the type attribute #52

Closed varshavaradarajan closed 6 years ago

varshavaradarajan commented 6 years ago

There has been a schema migration to use the same xml element to represent different types of artifacts. Here's the PR that introduced the change - https://github.com/gocd/gocd/pull/4278

<artifact src="foo" dest="bar" />
<test src="baz" />

gets converted to

<artifact type="build" src="foo" dest="bar" />
<artifact type="test" src="baz" />
dudadornelles commented 6 years ago

Thanks for the heads up!

dudadornelles commented 6 years ago

It would seem this https://github.com/gocd-contrib/gomatic/pull/53 does the trick for this issue?

arvindsv commented 6 years ago

👍

dudadornelles commented 6 years ago

Awesome thanks to all involved :)