search

gocd-contrib / gomatic

A Python API for configuring GoCD
https://pypi.python.org/pypi/gomatic
MIT License
142 stars 59 forks source link

Update fetchartifacts tag to reflect changes introduced in gocd 1.8.6 #54

Closed heinzbeinz closed 6 years ago

heinzbeinz commented 6 years ago

See: https://docs.gocd.org/current/configuration/configuration_reference.html#fetchartifact

ghost commented 6 years ago

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

dudadornelles commented 6 years ago

Hey, thanks for working on this - I see you didn't add any check for the gocd version but it seems to me that your changes should always be backwards compatible, is that right?

heinzbeinz commented 6 years ago

I have to admit: I don't know. We updated to the newest gocd and our deployment with gomatic did no longer work, so I made a quick fix. If the version check is easy, it would certainly make sense to add it. But maybe gocd simply ignores superfluous tags and then the fix is backward compatible.

dudadornelles commented 6 years ago

Ok I payed more attention to the change and also ran the integration tests and all looks good - I believe you are right and it makes total sense, older versions of gocd will simply ignore the "origin" tag. We could add the version check but that would add unnecessary complexity so I'll just merge this. I'll release it as 0.6.1.

Thanks again!