search

gocd-contrib / gomatic

A Python API for configuring GoCD
https://pypi.python.org/pypi/gomatic
MIT License
142 stars 60 forks source link

The attribute origin is not allowed to appear in element fetchartifact on versions under 18.2 #56

Closed biharck closed 5 years ago

biharck commented 6 years ago

What

The default value for the origin attribute has been set to None. Also, the xsd schema has been updated removing the requirement. And condiction was added in order to verify the nullable value.

Why

Versions lower than 1.8.2 don't allow the origin attribute within fetchArtifact element. The changes made on https://github.com/gocd-contrib/gomatic/commit/5274606037d3dff91c16952548a20351c9928b37 are breaking Gomatic due to Attribute ‘origin’ is not allowed to appear in element ‘fetchartifact’.

So, the changes are just to guarantee Gomatic to still work on GoCD as 1.8.2.

dudadornelles commented 5 years ago

Somehow our integration tests didn't catch this, it would be nice to understand why

dudadornelles commented 5 years ago

Released as 0.6.3