gocd-contrib / gomatic

A Python API for configuring GoCD
https://pypi.python.org/pypi/gomatic
MIT License
142 stars 60 forks source link

Adds origin parameter to be appended on fetchartifact element for Tasks config XML #59

Closed diogodafs closed 5 years ago

diogodafs commented 5 years ago

The previous commit (for missing attribute on Task object serialization) missed appending the new origin attribute to fetchartifact element on Tasks.

It's important to mention that the origin field will only be added to fetchartifact element if explicitly set on FetchArtifactTask method, so it does not break retrocompatiblity mentioned on #56

ghost commented 5 years ago

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Diogo Silva seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.