search

gocd / docker-gocd-agent-docker-dind

Apache License 2.0
9 stars 28 forks source link

Unable to modify wrapper-properties.conf #11

Closed erd0s closed 4 years ago

erd0s commented 4 years ago

I'd like to set go.agent.status.api.bind.host=0.0.0.0 in my wrapper properties file so that I can have healthchecks on the agent from outside the container, but as far as I can tell it's not possible to modify wrapper-properties.conf because of this line in the docker-entrypoint.sh file (usage of > instead of >> overwrites the existing file).

Is this by design? Or would it make sense to change it to something like:

echo "wrapper.app.parameter.100=-serverUrl" >> /go-agent/wrapper-config/wrapper-properties.conf

..allowing the file to be linked from the godata directory and not be overwritten?

Happy to put in a PR with updated readme, let me know

Lastin commented 4 years ago

Made a PR with suggested solution https://github.com/gocd/docker-gocd-agent-dind/pull/12

ketan commented 4 years ago

Try passing -e AGENT_STARTUP_ARGS=-Dgo.agent.status.api.bind.host=0.0.0.0?

erd0s commented 4 years ago

Ah, right, yes that works perfectly thanks @ketan