gocd / docker-gocd-agent

GoCD Agent Docker image
https://hub.docker.com/r/gocd/
47 stars 37 forks source link

The gocd-agent-docker-dind image doc has a little mistake #80

Closed FaustYKKN closed 5 years ago

FaustYKKN commented 5 years ago

The demo commond in docs of gocd-agent-docker-dind docker run -itd -e GO_SERVER_URL=https://$(docker inspect --format='{{(index (index .NetworkSettings.IPAddress))}}' angry_feynman):8154/go gocd/gocd-agent-docker-dind:v18.10.0, without --privileged flag, make the agent container cannot start the docker daemon.

arvindsv commented 5 years ago

/cc @sheroy will look at this.

arvindsv commented 5 years ago

Thank you, @FaustYKKN. Fixed in https://github.com/gocd/gocd-agent-docker-dind/pull/3