search

gocd / go-cookbook

Cookbook that installs and configures the open-source ThoughtWorks Studios GoCD product
http://www.gocd.org/
Apache License 2.0
44 stars 66 forks source link

Add berksfile for dependent cookbooks. #102

Closed varshavaradarajan closed 7 years ago

varshavaradarajan commented 7 years ago

@GaneshSPatil

tomzo commented 7 years ago

Hi @varshavaradarajan, Why would we want the Berksfile in application cookbook with explicit deps? Also having metadata statement in Berskfile already declares these dependencies.

varshavaradarajan commented 7 years ago

Oh, alright. Didn't notice the metadata.rb file. I'll update the dependencies there.

tomzo commented 7 years ago

Also, usually adding such strict dependencies will piss users off. If someone is using this cookbook together with any other which depends on e.g. java but the other has `'java', '~> 1.48.0' then there will be a conflict and one cannot that cookbook. Why do you need these constraints at all? Cookbook works with many versions of these