gocd / go-cookbook

Cookbook that installs and configures the open-source ThoughtWorks Studios GoCD product
http://www.gocd.org/
Apache License 2.0
44 stars 66 forks source link

Broken with Chef 13 #113

Closed barrowkwan closed 7 years ago

barrowkwan commented 7 years ago

with this error

Property resources of resource gocd_agent overwrites an existing method.

varshavaradarajan commented 7 years ago
Deprecated features used!
  Property `retries` of resource `java_ark` overwrites an existing method. Please use a different property name. This will raise an exception in Chef 13. at 1 location:
    - /var/chef/cache/cookbooks/java/resources/ark.rb:46:in `class_from_file'
   See https://docs.chef.io/deprecations_property_name_collision.html for further details.
  Property `retry_delay` of resource `java_ark` overwrites an existing method. Please use a different property name. This will raise an exception in Chef 13. at 1 location:
    - /var/chef/cache/cookbooks/java/resources/ark.rb:47:in `class_from_file'
   See https://docs.chef.io/deprecations_property_name_collision.html for further details.
  Property `resources` of resource `gocd_agent` overwrites an existing method. Please use a different property name. This will raise an exception in Chef 13. at 1 location:
    - /var/chef/cache/cookbooks/gocd/resources/agent.rb:17:in `class_from_file'
   See https://docs.chef.io/deprecations_property_name_collision.html for further details.
  Property `resources` of resource `gocd_agent_autoregister_file` overwrites an existing method. Please use a different property name. This will raise an exception in Chef 13

Cannot support Chef 13 until the dependent cookbooks also make the change (in our case java, and their latest doesn't mention it). I'll keep an eye out for their update and make the change. Meanwhile , I'll add a deprecation notice for our custom resources making use of the reserved property names and tell users that we are going to rename them. Sound ok?

barrowkwan commented 7 years ago

sounds good. thanks!