search

gocd / go-cookbook

Cookbook that installs and configures the open-source ThoughtWorks Studios GoCD product
http://www.gocd.org/
Apache License 2.0
45 stars 66 forks source link

[WIP] Upgrade to java 11 using adoptopenjdk #139

Closed varshavaradarajan closed 5 years ago

varshavaradarajan commented 5 years ago

Fails on debian because of https://github.com/gocd/gocd/blob/master/buildSrc/src/main/groovy/com/thoughtworks/go/build/DebPackagingTask.groovy#L36. Since the java cookbook doesn't install multiple versions of java, in order to use 11, the deb pkg's dependency on java 8 should be removed. Which is in 6 months time.

ketan commented 5 years ago

@varshavaradarajan: I'm going to discuss with the team whether we should package an appropriate adoptopenjdk along with the .deb/.rpm packages, and remove the dependency on OS packages altogether.

Obviously, if users want to install via the .zip installers, they'd still need to get it from somewhere.

ketan commented 5 years ago

Closing. Newer versions of gocd will just package an appropriate JRE.

For users wanting to use a custom JRE, they can install it using a different cookbook and provide a config option to point to the appropriate JRE.