gocd / go-cookbook

Cookbook that installs and configures the open-source ThoughtWorks Studios GoCD product
http://www.gocd.org/
Apache License 2.0
45 stars 66 forks source link

Windows Go Agent Install Path problem #28

Closed rwilkin-mw closed 9 years ago

rwilkin-mw commented 9 years ago

In the recipe agent_windows, the following 'opts' is specified in the following way:

opts = ""
opts << "/SERVERIP=#{server_ip}" if node['go']['agent']['server_host']
opts << "/D=#{install_path}" if node['go']['agent']['install_path']

The problem is, if both the ['go']['agent']['server_host'] and ['go']['agent']['install_path'] are specified, the /D option gets mangled because there is no space between the two options.

tpbrown commented 9 years ago

Thanks for catching that.

Is this a priority for you? I can likely look at it later today.

rwilkin-mw commented 9 years ago

If you would, please.

rwilkin-mw commented 9 years ago

Thanks!