Maintenace and cleanup

[tomzo]

I have marked a few points which could be improved https://github.com/gocd-contrib/go-cookbook/commit/867088c17a587a3d3e01b5e4a275d48c07aa466d Issues I am planning to fix:

• test compatibility with chef 11 and 12
• attempt to make node['go']['version'] = 'stable' by default (#26). Is there an URL that would return what is stable currently?
• refactor and document the backup and restore functionality which apparently works, but has no tests or readme
• add more detailed integration tests (test auto-registration of agents in particular that they are added and enabled)
• add chefspec tests
• extend readme on how to use the cookbook on various platforms
• I'd also like to assume that chefdk is now the primary development toolset
• setup snap-ci to run stylechecks, chefspec and kitchen integration tests in docker (as @ketan already did). If this will not be possible in long-term then I will be running integration tests on openstack locally.

I think it would also be nice to have LWRP for go agents. I will describe in separate issue. I'd also like to split recipes into just installing Go packages and actually managing services. Default would be still to do both. Probably I will write more tests before I add or refactor anything so that I will see if I break anything.

I will not do this all at once, but in time I should cover all of it.

[mjuszczak]

I'm happy to help, let me know.

[tomzo]

@mjuszczak That's great!

We have development branches at the moment.

@ketan has made some efforts to make a minimalistic version of the cookbook in https://github.com/ketan/go-cookbook/tree/develop . It is good enough to set up server and agents (at least on linux).

I have all his changes in chefspec branch where I also

• switched to using bundler and
• added initial chefspec tests

Integration tests are done in test-kitchen with docker containers.

You can run tests after installing chefdk with

chef exec bundle install
chef exec bundle exec rake unit
chef exec bundle exec rake integration:docker

There are snap-ci builds running at https://preview.snap-ci.com/tomzo/go-cookbook/branch/chefspec

Do you have some something particular in mind?

The way I see it:

• It would be nice to add chefspec on all supported platforms.
• You could update the Vagrantfile if you are running it with virtualbox.
• I created go_agent LWRP issue #56, but haven't started working on it yet
• I haven't tested this changes on windows yet

[ketan]

As you can probably see from my message on the gitter channel, I've not had much time to look into this.

@tomzo, I do have a very rough and possibly very ugly recipe to setup a agent go on window using both the installer an another via a zip file. Both of them support auto registration of agents, the zipfile requires that java installed via the java cookbook...

This should take care of at-least one OS as part of #50 :)

I'm afraid that I'm going to be going on leave anytime soon, and won't be able to get back to this issue for atleast another couple of weeks. I'm going to dump whatever recipes I have with windows support, in another comment for someone to pick it up.

[ketan]

I'm going to dump whatever recipes I have with windows support, in another comment for someone to pick it up.

I've added the recipes on #50 instead of this issue.

[mjuszczak]

@tomzo My skills would probably best be utilized on Linux-only work -- I don't have much ability to work with/test Windows. I use test kitchen with serverspec/chefspec in my cookbooks, so could handle some work on that end and/or on the minimalistic cookbook. Otherwise, can take a peek at the agent LWRP. Let me know!

[tomzo]

@mjuszczak I believe we should have near 100% chefspec coverage on all platforms before creating LWRP. test-kitchen is quite good at this point. Installing server and agents works fine on linux already.

You can pick up chefspec work from my branch and write cases for debian and centos. If you do, I could cover windows with what ketan has left and we could release it as 1.0.0. It would be good enough to handle linux and windows agents and linux server.

Then we can start working on LWRPs.

[mjuszczak]

@tomzo Deep apologizes for not being able to jump on any of this late last year. I got unexpectedly swamped. Thanks for all of your work on this.