gocd / go-cookbook

Cookbook that installs and configures the open-source ThoughtWorks Studios GoCD product
http://www.gocd.org/
Apache License 2.0
45 stars 66 forks source link

Proposed 1.3 release #89

Closed tomzo closed 7 years ago

tomzo commented 8 years ago

I'll be testing this in next days before releasing. Any feedback welcome.

ketan commented 8 years ago

FYI. We have turned on the http protocol so there is no need for apt-protocol-https anymore. As long as you are importing the GPG keys properly, the packages can be guaranteed to be untempered.

philoserf commented 8 years ago

Results of the Rakefile style check:

Starting Foodcritic linting...
FC009: Resource attribute not recognised: go-cookbook/recipes/agent_windows_install.rb:21
FC009: Resource attribute not recognised: go-cookbook/recipes/server_windows_install.rb:13
FC019: Access node attributes in a consistent manner: go-cookbook/recipes/java.rb:2
philoserf commented 8 years ago

Results of Rakefile unit:chefspec check:

Finished in 29.99 seconds (files took 1.66 seconds to load)
155 examples, 0 failures

ChefSpec Coverage report generated...

  Total Resources:   59
  Touched Resources: 45
  Touch Coverage:    76.27%

Untouched Resources:

  ohai[reload_passwd_for_go_user]    gocd/recipes/agent_linux_install.rb:3
  apt_package[apt-transport-https]   gocd/recipes/repository.rb:4
  directory[/mnt/big_drive]          gocd/providers/agent.rb:9
  directory[/var/log/my-go-agent]    gocd/providers/agent.rb:9
  directory[/mnt/big_drive/config]   gocd/providers/agent.rb:15
  bash[setup init.d for my-go-agent]   gocd/providers/agent.rb:21
  link[/usr/share/my-go-agent]       gocd/providers/agent.rb:29
  bash[setup init.d for go-agent]    gocd/providers/agent.rb:21
  link[/usr/share/go-agent]          gocd/providers/agent.rb:29
  ohai[reload_passwd]                gocd/recipes/server_linux_install.rb:3
  apt_package[unzip]                 gocd/recipes/server_linux_install.rb:9
  http_request[verify_go-server_comes_up]   gocd/recipes/server.rb:16
  ruby_block[publish_autoregister_key]   gocd/recipes/server.rb:23
  yum_package[unzip]                 gocd/recipes/server_linux_install.rb:9