search

gocd / go-cookbook

Cookbook that installs and configures the open-source ThoughtWorks Studios GoCD product
http://www.gocd.org/
Apache License 2.0
45 stars 66 forks source link

Target platform not clearly specified #9

Closed pshomov closed 10 years ago

pshomov commented 10 years ago

Assumes Debian distro, fails on CentOS

scottmuc commented 10 years ago

https://github.com/ThoughtWorksInc/go-cookbook/blob/master/metadata.rb says it only supports ubuntu.

Regardless, it should be supporting CentOS too.

pshomov commented 10 years ago

Right, I meant not clearly specified in the readme text ;) Tried it on CentOS 6.4 failed, something about /etc/apt/... not being found I think, will come back with the proper error message.

On Mon, Mar 3, 2014 at 5:51 PM, Scott Muc notifications@github.com wrote:

https://github.com/ThoughtWorksInc/go-cookbook/blob/master/metadata.rbsays it only supports ubuntu.

Regardless, it should be supporting CentOS too.

— Reply to this email directly or view it on GitHubhttps://github.com/ThoughtWorksInc/go-cookbook/issues/9#issuecomment-36537137 .

scottmuc commented 10 years ago

Yeah, that's simply because CentOS uses yum. I believe there's a yum repository for Go as well. Not sure if I'll be able to tackle this anytime soon, but hopefully someone can. It's also going to be the requirement that introduces cross platform test-kitchen tests as well. Should be fun to work on :)

maxlinc commented 10 years ago

I've been thinking about trying it out just to give kitchen-rackspace a shot.

Does test-kitchen have some major benefits over testing with just Vagrant? I can easily create a Vagrantfile where "vagrant up --provider rackspace" launches machines on available images, meaning not just multiple distros, but multiple versions of each distro, and runs any provider I choose - including chef to test this cookbook.

On Thu, Mar 6, 2014 at 4:19 AM, Scott Muc notifications@github.com wrote:

Yeah, that's simply because CentOS uses yum. I believe there's a yum repository for Go as well. Not sure if I'll be able to tackle this anytime soon, but hopefully someone can. It's also going to be the requirement that introduces cross platform test-kitchen tests as well. Should be fun to work on :)

Reply to this email directly or view it on GitHubhttps://github.com/ThoughtWorksInc/go-cookbook/issues/9#issuecomment-36837605 .

scottmuc commented 10 years ago

The problem with that is that every contributor is expected to have a rackspace account. At least if they want to test things before submitting a PR.

The benefit of test-kitchen is the cross-platform testing. For now testing manually with vagrant was sufficient because there's only 1 platform (and 1 specific version of that platform).

maxlinc commented 10 years ago

Not really. Vagrant can work with as many or more providers than test-kitchen. You could do it purely with VirtualBox images, but the experience will be awful if you want to maintain tests for a large number of platforms.

The reason I'd recommend testing on the cloud isn't because it's necessary, but because it's better. If you want to test 20 supported platforms (including multiple versions of each distro), then using a public cloud:

I don't test-kitchen as solving that problem - you still need either massive downloads (if using the VirtualBox/Vagrant driver), a cloud account (if using kitchen-rackspace or another cloud driver) or some other way to access the 20 supported platforms.

I'd probably just test a single platform locally, though, and let CI do the heavy lifting to check the other 19 before merging to master.

On Thu, Mar 6, 2014 at 12:25 PM, Scott Muc notifications@github.com wrote:

The problem with that is that every contributor is expected to have a rackspace account. At least if they want to test things before submitting a PR.

The benefit of test-kitchen is the cross-platform testing. For now testing manually with vagrant was sufficient because there's only 1 platform (and 1 specific version of that platform).

Reply to this email directly or view it on GitHubhttps://github.com/ThoughtWorksInc/go-cookbook/issues/9#issuecomment-36912577 .

scottmuc commented 10 years ago

I pretty much agree with all of that :), just calling YAGNI until this repo gets to that point. Not having CentOS is the biggest gap here and what's most important to @pshomov.

pshomov commented 10 years ago

Hi guys,

No worries, I just went with docker and am experimenting with that. I appreciate your help!

Regards,

Petar

On Thu, Mar 6, 2014 at 6:29 PM, Scott Muc notifications@github.com wrote:

I pretty much agree with all of that :), just calling YAGNI until this repo gets to that point. Not having CentOS is the biggest gap here and what's most important to @pshomov https://github.com/pshomov.

— Reply to this email directly or view it on GitHubhttps://github.com/ThoughtWorksInc/go-cookbook/issues/9#issuecomment-36919861 .

maxlinc commented 10 years ago

Quick note for those that haven't been following the Vagrant blog. A lot of the challenges mentioned above may be solved with Vagrant 1.5 and Vagrant Cloud, which add box discoverability, and boxes 2.0 which let's a box support multiple providers.

In summary, vagrant is pretty amazing and @pshomov's choice to use kitchen-vagrant in #12 is a good one! :beers:

pdunnavant commented 10 years ago

This issue should be fixed by #12. CentOS support was added along with several test-kitchen tests in that pull request, so I think this issue can be closed.

tpbrown commented 10 years ago

Closed with #12 merge