search

gocd / go-cookbook

Cookbook that installs and configures the open-source ThoughtWorks Studios GoCD product
http://www.gocd.org/
Apache License 2.0
45 stars 66 forks source link

Redundant init.d file for golang go-agent #90

Closed xmik closed 7 years ago

xmik commented 7 years ago

Installing golang Go-agent from Debian package provides /etc/init.d/gocd-golang-agent file. Gocd cookbook also provides init.d file for golang go-agent. When using Gocd cookbook and 2 golang Go-agents, there are such files available after provisioning:

and /etc/init.d/gocd-golang-agent is redundant.

This issue is well resolved for java Go-agents: Go-agent Debian package provides /etc/init.d/go-agent file and then Gocd cookbook does this: https://github.com/gocd-contrib/go-cookbook/blob/bf4cfe2e1a5d870af0e6f26c11b249fbc8fd89c3/resources/agent.rb#L68 . I suggest the same way for golang Go-agents.

tomzo commented 7 years ago

Since 1.3.1 the golang-agent apt package is no longer used. We just download a binary and setup init scripts only via cookbook.