gocd / gocd-helm-chart

A Helm chart for www.gocd.org
Apache License 2.0
6 stars 8 forks source link

Provide a way to pull images from a private registry #24

Open varshavaradarajan opened 5 years ago

varshavaradarajan commented 5 years ago
Issue Type
Summary

The helm chart installs gocd/gocd-server and gocd/gocd-agent-alpine-* by default. These images are publicly available on dockerhub . Suppose a user wants to override the image to pull from a private registry, there is no option to do so. While secrets can (and should) be created outside of the helm chart installation, there is no imagePullSecrets in the (server|agent)-deployment yaml to reference the created secret. Related: https://kubernetes.io/docs/tasks/configure-pod-container/pull-image-private-registry/

Don't know how necessary this is to do though seeing as no one has raised a request for it.

Basic environment details