search

gocd / gocd

GoCD - Continuous Delivery server main repository
https://www.gocd.org
Apache License 2.0
7.1k stars 970 forks source link

autoregister.properties and environment variable support #992

Closed benzvan closed 4 years ago

benzvan commented 9 years ago

autoregister.properties file does not appear to support environment variables. If it did, this would make configuring agents much simpler.

ketan commented 9 years ago

Could you provide an example of some of the things you're looking to do?

benzvan commented 9 years ago

Sure,

Every one of our agents gets two resources based on the first part of their hostname so that we can identify the actual host or host group individually. So being able to set agent.auto.register.resources=${HOSTNAME%%.*} would allow us to use the same autoregister.properties by default and without using puppet to edit an .erb file.

ntnn commented 7 years ago

We require this as well. We have multiple agents per machine, some for different GoCD masters.

Putting the file in the installation directory renders it useless for us, since then all agents on the same machine would use the same properties - even though they are for different masters.

Making the agents configurable via parameters, environment variables or to allow more paths (e.g. in the home directory of the user) would make it much more useful.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had activity in the last 90 days. If you can still reproduce this error on the master branch using local development environment or on the latest GoCD Release, please reply with all of the information you have about it in order to keep the issue open. Thank you for all your contributions.