Correct compatibility of Ingress for Kubernetes 1.22 - Githubissues

gocd / helm-chart

Official GoCD Helm Chart Repository

Apache License 2.0

22 stars 21 forks source link

Correct compatibility of Ingress for Kubernetes 1.22 #23

Closed chadlwilson closed 2 years ago

chadlwilson commented 2 years ago

Fixes #16.

networking.k8s.io/v1beta1 of Ingress is gone in 1.22.
networking.k8s.io/v1 has been available since 1.19 but involves some changes as documented here
Additionally pathType is now mandatory, however only supported since Kubernetes 1.18.

These changes should be backward compatible, and mirror the way the new API serves up data created via the old API version.

Additionally

removed redundant nodeHttpsPort which is no longer used by the chart
added myself as maintainer
Changed lint+test to run across multiple k8s versiobs
Fixed test workflow to run only once on PRs, and release to only happen on master after tests complete

Tested

[X] Fresh install on 1.22 with ingress (default backend and specific hosts)
[X] Fresh install of old chart on 1.21 with Ingress, then upgrading to new chart
[X] Fresh install on 1.19 with ingress (default backend and specific hosts)