Closed artushin closed 10 months ago
Thanks for the PR - seems like a sensible change to me and relatively straightforward to validate. Will take a look soon.
Is it possible for you to allow changes to the PR from collaborators? Would like to make minor tweaks that are easier to "just make" than PR back-and-forth :-)
Is it possible for you to allow changes to the PR from collaborators? Would like to make minor tweaks that are easier to "just make" than PR back-and-forth :-)
For sure! Thanks for taking a look so quickly. I added you as a collaborator for the forked repo.
Ahh, sorry, didn't mean full collaborator on the forked repo - that's a bit extreme. Normally on PRs there is a check-box to the right hand side which effectively grants specific access to the branch associated with the PR while the PR is open. This one:
I think it's not ticked in this case?
@chadlwilson It's weird, I'm just not seeing that option on this PR. I totally don't mind that if you just accept the invite to collaborate on the repo. If we do end up making further changes, we'll be putting them back in your hands for PR anyway :)
Ahh no worries, I'll merge and tweak on master right prior to release, since there's no major blocker here.
Thanks @chadlwilson !
Apologies for the delay, finally got around to sanity testing and releasing this in https://github.com/gocd/kubernetes-elastic-agents/releases/tag/v3.9.1-501
This implements a configuration for setting timeouts for requests to the k8s cluster. GKE has been consistently outside the default timeout threshold for us, so we need a way to set
.withRequestTimeout(pluginSettings.getClusterRequestTimeout())
on the Kubernetes Client.