gocircuit / circuit

Circuit: Dynamic cloud orchestration http://gocircuit.org
Apache License 2.0
1.98k stars 160 forks source link

Migrate from codegangasta/cli to urfave/cli #29

Closed lthibault closed 7 years ago

lthibault commented 7 years ago

Hi Petar,

As codegangsta/cli is deprecated in favor of urfave/cli, the present pull-request replaces the former with the latter in the circuit project. Also, error handling in the main binary is adjusted to leverage the updated cli.ActionFunc API.

Best regards, Louis

maymounkov commented 7 years ago

Hi Louis. Thanks for this patch. i'm on vacation for two weeks. when i get back i will help check this in.

thanks again Petar

On Thursday, October 20, 2016, Louis Thibault notifications@github.com wrote:

Hi Petar,

As codegangsta/cli is deprecated in favor of urfave/cli, the present pull-request replaces the former with the latter in the circuit project. Also, error handling in the main binary is adjusted to leverage the updated cli.ActionFunc API.

Best regards,

Louis

You can view, comment on, or merge this pull request online at:

https://github.com/gocircuit/circuit/pull/29 Commit Summary

  • Switched from codegangsta/cli to urfave/cli. The former is no longer maintained.
  • add makefile
  • Moved to new cli interface. Improved error handling
  • Updated Makefile

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/gocircuit/circuit/pull/29, or mute the thread https://github.com/notifications/unsubscribe-auth/AGD7Ylv9lnXJZDWeqfyzEAeixORjMbCvks5q2A7FgaJpZM4KcwjC .

petar commented 7 years ago

Merged. Thanks for the update.