[WIP] Access plans reprise - Githubissues

gocodebox / lifterlms-rest

LifterLMS REST API Feature Plugin

6 stars 7 forks source link

[WIP] Access plans reprise #224

Closed eri-trabiccolo closed 3 years ago

eri-trabiccolo commented 3 years ago

Description

WIP Adresses issues raised in https://github.com/gocodebox/lifterlms-rest/issues/49#issuecomment-775460794

[x] limit to 6 access plan per product
[x] expose access plan permalink
[x] move some of the "static" code from schema definitions into their own schema files
[ ] cleanup some of the codeclimate errors without too much additional effort

How has this been tested?

manually, new and existing unit tests

Screenshots

n/a

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] My code has been tested.
[x] My code passes all existing automated tests.
[x] My code follows the LifterLMS Coding & Documentation Standards.

eri-trabiccolo commented 3 years ago

this looks good to me but since you've added a bunch of new functions I'd like to see those tested <3

Yeah, on it :D <3