search

gocodebox / lifterlms-rest

LifterLMS REST API Feature Plugin
6 stars 7 forks source link

Fix issue when updating a free access plan #268

Closed eri-trabiccolo closed 2 years ago

eri-trabiccolo commented 2 years ago

Description

Fixes #267

How has this been tested?

manually and with new unit tests

Screenshots

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

pondermatic commented 2 years ago

While reviewing this, I found a typo in LLMS_REST_Access_Plans_Controller::update_additional_object_fields() that is likely causing a bug. Should I open up a new issue?

eri-trabiccolo commented 2 years ago

LLMS_REST_Access_Plans_Controller::update_additional_object_fields()

Thanks @pondermatic. I'm fixing it in the same PR :D

eri-trabiccolo commented 2 years ago

@pondermatic can you give another look please?