search

gocodebox / lifterlms-rest

LifterLMS REST API Feature Plugin
6 stars 7 forks source link

Enrollment status update provides two triggers #278

Closed pondermatic closed 1 year ago

pondermatic commented 2 years ago

https://github.com/gocodebox/lifterlms-rest/blob/a12d8641a711087e5d7f95c6b211b8800644fa69/includes/server/class-llms-rest-enrollments-controller.php#L1128

LLMS_REST_Enrollments_Controller::handle_status_update() is giving an extra trigger argument to LLMS_Student::enroll().

The extra parameter was added in commit 99a0adb68aeb56dbebcb9a47622651506f34017e.

eri-trabiccolo commented 2 years ago

Niiiiice

eri-trabiccolo commented 2 years ago

Although this doesn't introduce any issue at the moment, right? The third parameter is superfluous, but the second parameter is correct.

pondermatic commented 2 years ago

That's good that the 2nd parameter is correct. Passing an extra parameter doesn't seem to generate an error.