Stop returning an error when updating resources properties with a new value equal to the saved one

gocodebox / lifterlms-rest

LifterLMS REST API Feature Plugin

6 stars 7 forks source link

Stop returning an error when updating resources properties with a new value equal to the saved one #284

Closed eri-trabiccolo closed 2 years ago

eri-trabiccolo commented 2 years ago

Description

Fixes #222 Fixes #289 Requires https://github.com/gocodebox/lifterlms/pull/2129

How has this been tested?

existing unit tests and new unit tests.

Screenshots

Types of changes

New feature (non-breaking change which adds functionality)

Checklist:

[x] My code has been tested.
[x] My code passes all existing automated tests.
[x] My code follows the LifterLMS Coding & Documentation Standards.

eri-trabiccolo commented 2 years ago

Minor changes, looks good overall.

I haven't pulled down to check but I'm going to assume that overall tests succeed with the unmerged gocodebox/lifterlms#2129?

I (unit) tested it locally with that pull branch.

thomasplevy commented 2 years ago

Hey @eri-trabiccolo I was waiting for you to come back for this:

Since https://github.com/gocodebox/lifterlms/pull/2129 is merged into dev, the phpunit tests against the "nightly" (dev) branch in core should be passing but this one test is failing still: https://github.com/gocodebox/lifterlms-rest/runs/6365733767?check_suite_focus=true

Is there something else that needs to change in core to make that test work or is it a faulty test?

eri-trabiccolo commented 2 years ago

Oh yeah, you need to raise the llms version to 6.5.0...

thomasplevy commented 2 years ago

Oh do I need to do that? :wink:

Let's ship it. I'll build a core release tomorrow with REST stuff included if you can get this set of changes released