Closed alaa-alshamy closed 6 months ago
The possible solutions:
but i don't know what you prefer
@alaa-alshamy
Thanks for reporting this, we'll work on getting this fixed in a future version
@thomasplevy Any news here ?
@alaa-alshamy I've prioritized this as a future update and haven't begun work on it yet. Once we start working on it it'll be moved out of the "Future" milestone and assigned to one of us.
Thanks for your patience.
There were just three strings that used the double quotes, so we reworded them slightly to not need an apostrophe. This will be resolved when this feature branch is merged and released: https://github.com/gocodebox/lifterlms/commit/fa84d1bc36f4519bdb82378e65a3a7ea48829847
Reproduction Steps
see this screenshot:
Technical description
After some investigation i figured that those texts are not added to the POT file because they are not added to the "get_strings" function in this line: https://github.com/gocodebox/lifterlms/blob/trunk/includes/class.llms.l10n.js.php#L38
and this file actually compiled automatically via the gulp as described in the head
And i think the gulp script not adding them because those texts used in double quote in this line: https://github.com/gocodebox/lifterlms/blob/trunk/assets/js/builder/Schemas/Lesson.js#L39
and the gulp script expect them to be in single quote in this line: https://github.com/gocodebox/lifterlms-lib-tasks/blob/master/tasks/pot-js.js#L28
So if you searched about
LLMS.l10n.translate( "
you will find all those texts i meanExpected Behavior
Actual Behavior
Error Messages / Logs